Switch plan(int) to plan(bigint) #348
Conversation
A useful test pattern is to define a matrix of tests in a table or view by building a cartesian join of multiple dimensions. If you do that, you'll want to do something along the lines of SELECT plan( 0 + <some number of static tests> + (SELECT count(*) FROM test_view) ); Because count(*) returns bigint doing this with plan(int) forces you to cast the output of count(*) to int. Switching plan() to accept a bigint removes the need for that cast.
|
@theory shouldn't this PR have kicked off an automated test run? |
|
It would have if you didn't keep changing your damn GitHub account name, @jnasbyupgrade! Is this who you are now? Currently the collaborators are: 
|
| @@ -10,6 +10,9 @@ Revision history for pgTAP | |||
| to Jim Nasby for reporting the issue (#234) Rodolphe Quiédeville for for the | |||
| pull request (#339). | |||
| * Added `index_is_partial()`, thanks to Rodolphe Quiédeville (#342). | |||
| * Change plan() to accept bigint. While only an insane person would need more | |||
| than 2^31 tests, the bigint version makes calling plan with the count(*) of | |||
There was a problem hiding this comment.
Isn't it just as easy to use plan(COUNT(*)::int)?
There was a problem hiding this comment.
Yes... but that's kinda annoying and not necessarily obvious.
|
Ahh, didn't realize tests were limited to contributors. You can remove nasbyj since I no longer work at Amazon. This is my new work account. I can also just do things from my personal account if you'd rather that. |
|
Whichever you prefer. Maybe if @jnasbyupgrade is another work account it should be your personal account? @decibel already had the permissions. |
A useful test pattern is to define a matrix of tests in a table or view by building a cartesian join of multiple dimensions. If you do that, you'll want to do something along the lines of
SELECT plan(
0
Because count() returns bigint doing this with plan(int) forces you to cast the output of count() to int. Switching plan() to accept a bigint removes the need for that cast.